Re: [RFC PATCH BlueZ] event: Remove unused dev_class parameter from btd_event_conn_complete()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Johan,

On Tue, Mar 27, 2012 at 7:55 AM, Johan Hedberg <johan.hedberg@xxxxxxxxx> wrote:
> Hi Lizardo,
>
> On Mon, Mar 26, 2012, Anderson Lizardo wrote:
>> This parameter is not being used by hciops nor mgmtops.
>> ---
>>  plugins/hciops.c  |    5 ++---
>>  plugins/mgmtops.c |    3 +--
>>  src/event.c       |    2 +-
>>  src/event.h       |    2 +-
>>  4 files changed, 5 insertions(+), 7 deletions(-)
>
> The right fix is to make use of this parameter instead of removing it.
> If btd_device has a variable for it, it should be updated and we should
> also write it to storage.

Regarding "If btd_device has a variable for it", I checked and only
btd_adapter has this variable. So I think we only need to write it to
storage (and it will be used later by Device's GetProperties).

Regards,
-- 
Anderson Lizardo
Instituto Nokia de Tecnologia - INdT
Manaus - Brazil
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux