Hi Johan, On Tue, Mar 27, 2012 at 7:59 AM, Johan Hedberg <johan.hedberg@xxxxxxxxx> wrote: > Hi Lizardo, > > On Mon, Mar 26, 2012, Anderson Lizardo wrote: >> This reverts commit fd1ac97806d4531cb54523b3d694899afce281e7. It seems >> the "entered" param is not used anymore. >> --- >> doc/agent-api.txt | 8 +------- >> 1 files changed, 1 insertions(+), 7 deletions(-) > > Why do you want to remove this? How else can we relay key press > notifications to the user? Like with your other patch the fact that some > code is not used doesn't necessarily mean that it should be removed but > that something needs to be added to make it useful. That's the reason I sent as RFC. I needed input like this :) Usually patches are more visible here than abstract questions. It also shows specifically where the "dangling part" is. Also note that these two places lacked some sort of TODO/FIXME comment. I could simply ask, but just sending this RFC patch seemed more effective. > Also, it seems we've forgotten this part from the mgmt API as there's no > event specified for it at the moment. Will you take care of this for mgmtops? If so, I can just fix the dev_class patch, which I think has the kernel side in place already. Best Regards, -- Anderson Lizardo Instituto Nokia de Tecnologia - INdT Manaus - Brazil -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
