Hi Chen Ganir: On Mon, Mar 26, 2012 at 12:25 PM, <chen.ganir@xxxxxx> wrote: > From: Chen Ganir <chen.ganir@xxxxxx> > > Add Device Information Service GATT Client for reading peer > device PNP_ID and store it. > > This is v2 of the patch set, removing some unused code to > eliminate compilation warnings. I am afraid of race conditions between HoG and DIS services. ATT is a "serial" protocol, however there is no guarantee that PNP ID characteristic value will be available before creating uhid device. It depends on the probing order AND when the commands are added in the GAttrib queue. IMO, the alternatives are: 1. move the DIS/PnP discovery to the create device "procedure" 2. create plugin states and dependency before probing 3. uuid "notification" mechanism": callback gets called when a new value is available for a given characteristic Opinions? BR, Claudio -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html