Re: [PATCH v2 5/5] DeviceInfo: Read PNP ID

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Chen,

On Mon, Mar 26, 2012 at 11:25 AM,  <chen.ganir@xxxxxx> wrote:
> diff --git a/src/device.c b/src/device.c
> index 3b772ee..dad8c26 100644
> --- a/src/device.c
> +++ b/src/device.c
> @@ -131,6 +131,7 @@ struct btd_device {
>        gchar           *path;
>        char            name[MAX_NAME_LENGTH + 1];
>        char            *alias;
> +       uint16_t        vendor_src;
>        uint16_t        vendor;
>        uint16_t        product;
>        uint16_t        version;
> @@ -377,6 +378,11 @@ static DBusMessage *get_properties(DBusConnection *conn,
>                dict_append_entry(&dict, "Vendor", DBUS_TYPE_UINT16,
>                                                        &device->vendor);
>
> +       /* Vendor Source*/
> +       if (device->vendor_src)
> +               dict_append_entry(&dict, "VendorSource", DBUS_TYPE_UINT16,
> +                                                       &device->vendor_src);
> +

* How does this work for BR/EDR devices (without GATT)? Is zero a
valid value for these devices?

* You need to update doc/device-api.txt

* Vendor Source looks like uint8, but you save it as uint16. Yes, I
know there is no "uint8" for d-bus, but just wondering why "byte"
cannot be used here.

Regards,
-- 
Anderson Lizardo
Instituto Nokia de Tecnologia - INdT
Manaus - Brazil
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux