Lizardo, > -----Original Message----- > From: Anderson Lizardo [mailto:anderson.lizardo@xxxxxxxxxxxxx] > Sent: Thursday, March 22, 2012 5:10 PM > To: Ganir, Chen > Cc: linux-bluetooth@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 0/2] GATT/ATT Cleanup > > Hi Chen, > > On Thu, Mar 22, 2012 at 9:37 AM, Anderson Lizardo > <anderson.lizardo@xxxxxxxxxxxxx> wrote: > > Hi Chen, > > > > On Thu, Mar 22, 2012 at 9:24 AM, <chen.ganir@xxxxxx> wrote: > >> From: Chen Ganir <chen.ganir@xxxxxx> > >> > >> Move gatt related primary and characteristic definitions > >> from the att.h to gatt.h (ATT does not define services and) > >> characteristics - those are GATT terms. > >> > >> Chen Ganir (2): > >> GATT: Rename service and char structs > >> GATT: replace start/end with att_range > >> > >> attrib/att.h | 13 ------------- > >> attrib/client.c | 22 +++++++++++----------- > >> attrib/gatt.c | 12 ++++++------ > >> attrib/gatt.h | 12 ++++++++++++ > >> attrib/gatttool.c | 6 +++--- > >> attrib/interactive.c | 6 +++--- > >> src/adapter.c | 11 ++++++----- > >> src/device.c | 14 +++++++------- > >> 8 files changed, 48 insertions(+), 48 deletions(-) > > > > Patches look good to me. > > Your patches do not compile with bootstrap-configure: > > In file included from proximity/manager.c:36:0: > proximity/monitor.h:33:41: error: ‘struct att_primary’ declared inside > parameter list [-Werror] > proximity/manager.c: In function ‘primary_uuid_cmp’: > proximity/manager.c:57:23: error: dereferencing pointer to incomplete > type > proximity/manager.c: In function ‘attio_device_probe’: > proximity/manager.c:78:8: error: passing argument 3 of > ‘monitor_register’ from incompatible pointer type [-Werror] > proximity/monitor.h:31:5: note: expected ‘struct att_primary *’ but > argument is of type ‘struct att_primary *’ > proximity/manager.c:78:8: error: passing argument 4 of > ‘monitor_register’ from incompatible pointer type [-Werror] > proximity/monitor.h:31:5: note: expected ‘struct att_primary *’ but > argument is of type ‘struct att_primary *’ > proximity/manager.c:78:8: error: passing argument 5 of > ‘monitor_register’ from incompatible pointer type [-Werror] > proximity/monitor.h:31:5: note: expected ‘struct att_primary *’ but > argument is of type ‘struct att_primary *’ > proximity/manager.c: In function ‘primary_uuid_cmp’: > proximity/manager.c:58:1: error: control reaches end of non-void > function [-Werror=return-type] > cc1: all warnings being treated as errors > > > Please fix this and send a new version. Regards, Thanks. I'll check that again and send patches in a few moments. > -- > Anderson Lizardo > Instituto Nokia de Tecnologia - INdT > Manaus - Brazil Thanks, Chen Ganir -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
