Hi Ulisses, On Thu, Mar 22, 2012 at 04:00:38PM -0300, Ulisses Furquim wrote: > >> > Simplify L2CAP timers logic. Previous logic was hard to understand. > >> > Now we always hold(chan) when setting up timer and put(chan) only > >> > if work pending and we successfully cancel delayed work. > >> > > >> > If delayed work is executing it will put(chan) itself. > >> > >> The description is a lot better, thanks. However, I don't see why this > >> change is an improvement. The old code could be hard to read but then > >> we need probably some comments to clarify it, just that IMHO. > > > > Agree with you here. > > > > After further investigation I think that current code is OK, Gustavo could > > you revert the patch. > > Thank you for checking this. What about a patch from you documenting > this? I already saw your commit with the missing _put(chan) in the > workers, which was great, thanks. I've just sent a patch with comments how timers work. Best regards Andrei Emeltchenko -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
