Hi, On Wed, Mar 21, 2012 at 2:56 AM, CHETHAN TN <chethan.tn@xxxxxxxxxxx> wrote: > > In the above patch the function "attr_to_str" have been taken from audio/media.c file. > Since there migth be few functions that will be used commonly in audio/avrcp.c and audio/media.c why can't > such funtions moved to a common file?. Actually we might want to handle this in media.c, so perhaps we can reuse the callback to gets an attribute or create a new one to fetch the text in case of this being dynamically, otherwise just have it inline in avrcp.h might be fine. -- Luiz Augusto von Dentz -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html