Hi Luiz, > > > > A new enum type is used to distinguish put and get transfers. > > > > This is more convenient since it is done when registering the > > transfer, and not when it is actually started. The main benefits > would be: > > - Some actions can be taken during creation, such as opening > files. > > - session.c gets simplified. > > - The size of a put transfer can be exposed in D-Bus, while > queued. > > - The type of transfer (put or get) can be exposed in D-Bus. > > > > None of these D-Bus changes are included in this patch. > > In this case I would prefer register_put/register_get instead of yet > another parameter and a enum with 2 values. > The main problem with this is that, when you want both file-based and memory-based transfers (see patch v0 07/11), you would have 4 possible combinations. Another (less relevant) reason is that some client code could be interested in checking this field. For example the agent needs to know that currently. I would even propose we make this field public in D-Bus in the future, so it would be weird that you have less information in the internal api. Cheers, Mikel -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
