Re: [PATCH v2 3/3] GATT: Profile support for EnableGatt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Chen,

On Wed, Mar 14, 2012 at 6:13 AM,  <chen.ganir@xxxxxx> wrote:
> @@ -28,6 +28,7 @@
>
>  #include <stdint.h>
>  #include <glib.h>
> +#include <errno.h>
>
>  #include "plugin.h"
>  #include "hcid.h"
> @@ -37,8 +38,8 @@
>  static int time_init(void)
>  {
>        if (!main_opts.gatt_enabled) {
> -               DBG("Attribute server is disabled");
> -               return -1;
> +               DBG("GATT is disabled !");
> +               return -ENOTSUP;

Your patch series looks ok, only a minor nitpick: I would use "GATT
support is disabled"  and skip the exclamation.

Regards,
-- 
Anderson Lizardo
Instituto Nokia de Tecnologia - INdT
Manaus - Brazil
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux