Hi Chen, On Tue, Mar 13, 2012, chen.ganir@xxxxxx wrote: > +static int deviceinfo_init(void) > +{ > + if (deviceinfo_manager_init() < 0) { > + return -EIO; > + } > + > + return 0; > +} Why not simply: return deviceinfo_manager_init(); > +int deviceinfo_manager_init(void) > +{ > + int ret; > + > + ret = btd_register_device_driver(&deviceinfo_device_driver); > + if (ret < 0) > + return ret; > + > + return 0; > +} Why not simply: return btd_register_device_driver(&deviceinfo_device_driver); Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html