Hey Johan, On Sun, Mar 11, 2012 at 15:02, Johan Hedberg <johan.hedberg@xxxxxxxxx> wrote: >> + >> +unlock: >> + hci_dev_unlock(hdev); >> + hci_dev_put(hdev); > > The dev_put here looks like a bug (probably from before the rebase when > this function was still calling hci_dev_get). Thanks. That's indeed a bug I missed in the rebase. I'll fix it. > > Other than that I don't see anything obviously wrong with the patch, > except that you might have maybe tried splitting it up a bit (not that > it's very big now either). Well the original was a single patch. And most of the code is pretty boilerplate. I'm thinking a single patch might be ok? Regards, Arik -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
