Hi Slawek,
On Tue, Mar 06, 2012, Slawomir Bochenski wrote:
> ---
> plugins/messages-dummy.c | 61 +++++++++++++++++++++++++++++++++++++++++++++-
> 1 files changed, 60 insertions(+), 1 deletions(-)
I've applied the first two in this set, but this one had some minor
stylistic issues:
> static ssize_t get_subdirs(struct folder_listing_data *fld, GSList **list)
> {
> - return 0;
> + DIR *dp;
> + char *path, *name;
> + size_t n = 0;
Please leave this initialization later in the function.
> + path = g_build_filename(fld->session->cwd_absolute, fld->name, NULL);
> + dp = opendir(path);
> +
> + if (dp == NULL) {
> + int err = errno;
For consistency, variables called "err" should have a negative value to
indicate error or 0 to indicate no error. So this should be:
err = -errno;
> + while ((name = get_next_subdir(dp, path)) != NULL) {
> + ++n;
When it doesn't really matter whether you use post- or pre-increment
just use post-increment since I think that's the most widely used one in
the code base.
> + if (fld->max != 0)
I'd prefer to have the test as > 0
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
