Why can't we get rid off the "typeof" keyword completely and using a
template similar approach:
===
#define bt_get_unaligned_tmpl(type, ptr) \
({ \
struct __p_s { \
type __v; \
} __attribute__((packed)); \
struct __p_s *__p = (struct __p_s*)(ptr); \
__p->__v; \
})
static inline uint64_t bt_get_le64(void *ptr)
{
return bt_get_unaligned_tmpl(uint64_t, ptr);
}
static inline uint64_t bt_get_be64(void *ptr)
{
return bswap_64(bt_get_unaligned_tmpl(uint64_t, ptr));
}
===
Okay, the macro parameter type is not encapsulated by parenthesis, but
it seems okay and working.
So it seems to be a very more portable solution (IMHO).
2012/3/5 Lucas De Marchi <lucas.demarchi@xxxxxxxxxxxxxx>:
> On Sun, Mar 4, 2012 at 8:27 PM, Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote:
>> Hi Patrick,
>>
>>> The compiler error is:
>>> /usr/include/bluetooth/bluetooth.h::131:9: error: invalid conversion from 'void*' to 'bt_get_le64(void*)::<anonymous struct>*'
>>> ...
>>>
>>> The reason is that C++, in contrast to C, does not allow conversion of
>>> void * to anything, and this code gets compiled as C++ when the app is
>>> written in C++. The macro with the assignment itself is older, but only
>>> recent Bluez starts to use it in inline functions, thus triggering the
>>> problem.
>>>
>>> This patch keeps the "struct __attribute__((packed))" magic and merely
>>> changes the typecast so that it works in C and C++. Like the existing
>>> macro this patch relies on support for typeof.
>>
>> so I am applying this patch now, but I still have no idea what kind of
>> stupid C++ compiler you are using. The section of this include is
>> clearly marked as C code:
>>
>> #ifdef __cplusplus
>> extern "C" {
>> #endif
>
> This only tells the compiler that this part has C linkage and not C++
>
>
> Lucas De Marchi
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
