Hi Michal,
On Thu, Mar 1, 2012 at 4:45 PM, Michal Labedzki
<michal.labedzki@xxxxxxxxx> wrote:
> According to the specification when duration and position are not
> supported then 0xFFFFFFFF should be returned. This patch avoid random
> position on stream where duration is not available.
Again you should quote the spec. Btw is really random or 0?
> ---
> audio/avrcp.c | 10 ++++++----
> audio/media.c | 3 ++-
> 2 files changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/audio/avrcp.c b/audio/avrcp.c
> index 2d29d56..e141030 100644
> --- a/audio/avrcp.c
> +++ b/audio/avrcp.c
> @@ -859,16 +859,18 @@ static uint8_t avrcp_handle_get_play_status(struct avrcp_player *player,
> return AVC_CTYPE_REJECTED;
> }
>
> - position = player->cb->get_position(player->user_data);
> pduration = player->cb->get_metadata(AVRCP_MEDIA_ATTRIBUTE_DURATION,
> player->user_data);
>
> - if (pduration != NULL)
> + if (pduration != NULL) {
> duration = htonl(GPOINTER_TO_UINT(pduration));
> - else
> + position = htonl(player->cb->get_position(player->user_data));
> + } else {
> duration = htonl(UINT32_MAX);
> + position = htonl(UINT32_MAX);
> + }
So the position cannot be known without the duration? What about live streams?
--
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
