Re: [PATCH 1/2] Bluetooth: Don't send unnecessary write_le_enable command

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Johan,

On Mon, Feb 27, 2012 at 8:41 PM,  <johan.hedberg@xxxxxxxxx> wrote:
> From: Johan Hedberg <johan.hedberg@xxxxxxxxx>
>
> If the local host features indicate that LE is already in the state that
> is desired there's no point in sending the HCI command to try to change
> the setting.
>
> Signed-off-by: Johan Hedberg <johan.hedberg@xxxxxxxxx>
> ---
>  net/bluetooth/mgmt.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
> index 27830f4..5373bc1 100644
> --- a/net/bluetooth/mgmt.c
> +++ b/net/bluetooth/mgmt.c
> @@ -1260,7 +1260,7 @@ static int set_le(struct sock *sk, u16 index, void *data, u16 len)
>        struct pending_cmd *cmd;
>        struct hci_dev *hdev;
>        int err;
> -       u8 val;
> +       u8 val, enabled;
>
>        BT_DBG("request for hci%u", index);
>
> @@ -1280,8 +1280,9 @@ static int set_le(struct sock *sk, u16 index, void *data, u16 len)
>        }
>
>        val = !!cp->val;
> +       enabled = !!(hdev->host_features[0] & 0x02);

You may use lmp_host_le_capable macro here. There are other places
in patch 2/2 you may wanna change too.

BR,

Andre
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux