Re: [PATCH 2/2] Bluetooth: Remove redundant read_host_features commands

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andrei,

On Tue, Feb 28, 2012, Andrei Emeltchenko wrote:
> > +	if (enable_le && test_bit(HCI_LE_ENABLED, &hdev->dev_flags)) {
> > +		cp.le = 1;
> 
> Do you mean here "true"?

No, cp.le is a u8 and not a bool.

> > -	cp.page = 0x01;
> > -	hci_send_cmd(hdev, HCI_OP_READ_LOCAL_EXT_FEATURES, sizeof(cp), &cp);
> > +	if (!status) {
> > +		if (sent->le)
> > +			hdev->host_features[0] |= 0x02;
> > +		else
> > +			hdev->host_features[0] &= !0x02;
> 
> BTW: what is 0x02? I saw it also in the second patch.

It's LMP_HOST_LE (i.e. the host features bit indicating that LE support
is enabled for the host). I fixed this to use the proper define before
applying the patch.

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux