Hi Luiz,
--------------------------------------------------
From: "Luiz Augusto von Dentz" <luiz.dentz@xxxxxxxxx>
Sent: Wednesday, February 22, 2012 5:45 PM
To: "Jaganath" <jaganath.k@xxxxxxxxxxx>
Cc: "Mikel Astiz" <mikel.astiz.oss@xxxxxxxxx>;
<linux-bluetooth@xxxxxxxxxxxxxxx>; "Mikel Astiz" <mikel.astiz@xxxxxxxxxxxx>
Subject: Re: [PATCH obexd v2 7/8] client: fix canceling queued transfers
Hi Jaganath,
On Wed, Feb 22, 2012 at 1:59 PM, Jaganath <jaganath.k@xxxxxxxxxxx> wrote:
If transfer->obex is unrefed here then the queued ABORT packet will not
be
sent.
This will create problem with PTS which requires ABORT command before
transport disconnection
Sorry. I think my comment is invalid since refcount will not be zero in
this
case.
Yep, this is the transfer reference, btw what test are you referring
to? I don't remember having problem with PTS in case of OpenOBEX and
we didn't wait any abort to be sent, but perhaps that is because
OpenOBEX had the blocking write logic while gobex wait for POLL_OUT,
Correct. Because of POLL_OUT logic only it is not working. It was working
earlier
with OpenOBEX.
perhaps we should flush when disconnecting. Anyway PTS is pretty lame
since the abort request is useless if it is followed by a disconnect.
I agree. But I think we should pass PTS test of qualification.
--
Luiz Augusto von Dentz
--
Regards
Jaganath
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth"
in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
