Hi Ulisses,
On Tue, Feb 21, 2012 at 03:01:55PM -0200, Ulisses Furquim wrote:
> Hi Andrei,
>
> On Tue, Feb 21, 2012 at 8:54 AM, Andrei Emeltchenko
> <Andrei.Emeltchenko.news@xxxxxxxxx> wrote:
> > From: Andrei Emeltchenko <andrei.emeltchenko@xxxxxxxxx>
> >
> >
> > Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@xxxxxxxxx>
> > ---
> > net/bluetooth/l2cap_core.c | 9 +++++++--
> > 1 files changed, 7 insertions(+), 2 deletions(-)
> >
> > diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
> > index c0640b7..0e4f4cb 100644
> > --- a/net/bluetooth/l2cap_core.c
> > +++ b/net/bluetooth/l2cap_core.c
> > @@ -300,7 +300,7 @@ void l2cap_chan_destroy(struct l2cap_chan *chan)
> > l2cap_chan_put(chan);
> > }
> >
> > -static void l2cap_chan_add(struct l2cap_conn *conn, struct l2cap_chan *chan)
> > +void __l2cap_chan_add(struct l2cap_conn *conn, struct l2cap_chan *chan)
> > {
> > BT_DBG("conn %p, psm 0x%2.2x, dcid 0x%4.4x", conn,
> > chan->psm, chan->dcid);
> > @@ -346,8 +346,13 @@ static void l2cap_chan_add(struct l2cap_conn *conn, struct l2cap_chan *chan)
> >
> > l2cap_chan_hold(chan);
> >
> > - mutex_lock(&conn->chan_lock);
> > list_add(&chan->list, &conn->chan_l);
> > +}
> > +
> > +void l2cap_chan_add(struct l2cap_conn *conn, struct l2cap_chan *chan)
> > +{
> > + mutex_lock(&conn->chan_lock);
> > + __l2cap_chan_add(conn, chan);
> > mutex_unlock(&conn->chan_lock);
> > }
>
> Same comment applies here. If we don't use the locked version, don't
> bother adding it.
It is used for example in the code below:
1 470 net/bluetooth/a2mp.c <<open_a2mp_chan>>
l2cap_chan_add(conn, chan);
2 917 net/bluetooth/l2cap_core.c <<l2cap_le_conn_ready>>
l2cap_chan_add(conn, chan);
3 1258 net/bluetooth/l2cap_core.c <<l2cap_chan_connect>>
l2cap_chan_add(conn, chan);
Best regards
Andrei Emeltchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
