Re: [PATCH obexd v3 3/6] client: fix incorrect error check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Mikel,

On Thu, Feb 16, 2012, Mikel Astiz wrote:
> -	obc_session_setpath(pbap->session, path, pbap_setpath_cb, pbap, err);
> -	if (err != NULL) {
> +	if (obc_session_setpath(pbap->session, path, pbap_setpath_cb, pbap,
> +									err)) {

I know it adds a little bit of extra code, but I think it'd make this a
bit more readable if you added a new "guint id" variable and do:

	id = obc_session_setpath(...);
	if (id > 0) {
		...
	}

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux