Hi Gustavo,
On Tue, Feb 14, 2012 at 04:39:55PM -0200, Gustavo Padovan wrote:
> > @@ -974,10 +987,8 @@ static void l2cap_conn_unreliable(struct l2cap_conn *conn, int err)
> > mutex_lock(&conn->chan_lock);
> >
> > list_for_each_entry(chan, &conn->chan_l, list) {
> > - struct sock *sk = chan->sk;
> > -
> > if (test_bit(FLAG_FORCE_RELIABLE, &chan->flags))
> > - sk->sk_err = err;
> > + l2cap_chan_set_err(chan, err);
>
> Why is this l2cap_chan_set_err()? This function wasn't holding the lock.
> Please justify this change.
You are right here, will change it to unlocked one.
Best regards
Andrei Emeltchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
