Hi Marcel, On Thu, Feb 09, 2012 at 03:28:45PM +0100, Marcel Holtmann wrote: > Hi Andrei, > > > When needed we take explicit lock. > > > > Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@xxxxxxxxx> > > --- > > net/bluetooth/l2cap_core.c | 6 ++---- > > 1 files changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c > > index ae08944..dcf4792 100644 > > --- a/net/bluetooth/l2cap_core.c > > +++ b/net/bluetooth/l2cap_core.c > > @@ -105,9 +105,8 @@ static struct l2cap_chan *l2cap_get_chan_by_scid(struct l2cap_conn *conn, u16 ci > > > > mutex_lock(&conn->chan_lock); > > c = __l2cap_get_chan_by_scid(conn, cid); > > - if (c) > > - lock_sock(c->sk); > > mutex_unlock(&conn->chan_lock); > > + > > return c; > > } > > so this is dangerous since now we are creating an imbalance with the > socket locks. Are we fixing that one later on? Yes, that will be fixed later on. Do you think that needs to be merged with the other code? Best regards Andrei Emeltchenko -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
