Hi Szymon, On Tue, Feb 7, 2012 at 10:08 AM, Szymon Janc <szymon.janc@xxxxxxxxx> wrote: >> >> Hmm, maybe we can clear ack timer only once if we check nsent in the >> end of l2cap_ertm_send() instead of potentially call it several times? >> Not sure if it's worth it or not, though. > > This is what __l2cap_send_ack is doing i.e. sends RR frame only if > l2cap_ertm_send() returned 0 (or error). Would be good to have this consistent. > > So maybe just clear ack timer when incrementing nsent for the 1st time? > > if (!nsent++) > __clear_ack_timer(chan); > But that means we would be clearing ack timer even for retransmit frames which Im not sure can be account as an ack? -- Luiz Augusto von Dentz -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
