Re: [PATCH] device: Fix segmentation fault removing devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Santiago,

On Tue, Jan 31, 2012 at 11:59 AM, Santiago Carot-Nemesio
<sancane@xxxxxxxxx> wrote:
> There is an unbalanced control regarding to the GATT channel and its
> attachid, we have to to update the attach id value by setting it to
> zero whenever we detach a GATT channel.

Can you detail how to reproduce the segfault? I want to test on my own setup.

Thanks

> ---
>  src/device.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/src/device.c b/src/device.c
> index c19acd4..9f749b7 100644
> --- a/src/device.c
> +++ b/src/device.c
> @@ -1734,6 +1734,7 @@ static void attrib_disconnected(gpointer user_data)
>        attrib_channel_detach(device->attrib, device->attachid);
>        g_attrib_unref(device->attrib);
>        device->attrib = NULL;
> +       device->attachid = 0;
>
>        if (device->auto_connect == FALSE)
>                return;
> @@ -1781,6 +1782,7 @@ static void primary_cb(GSList *services, guint8 status, gpointer user_data)
>
>        if (device->attios == NULL && device->attios_offline == NULL) {
>                attrib_channel_detach(device->attrib, device->attachid);
> +               device->attachid = 0;
>                g_attrib_unref(device->attrib);
>                device->attrib = NULL;
>        } else
> @@ -2854,7 +2856,7 @@ gboolean btd_device_remove_attio_callback(struct btd_device *device, guint id)
>        if (device->attios != NULL || device->attios_offline != NULL)
>                return TRUE;
>
> -       if (device->attachid) {
> +       if (device->attachid > 0) {
>                attrib_channel_detach(device->attrib, device->attachid);
>                device->attachid = 0;
>        }
> --
> 1.7.9
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Anderson Lizardo
Instituto Nokia de Tecnologia - INdT
Manaus - Brazil
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux