Hi, On Tue, Jan 31, 2012 at 1:11 PM, Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote: > Hi Andrei, > >> > > - cancel_delayed_work_sync(&conn->disc_work); >> > > + cancel_delayed_work(&conn->disc_work); >> > >> > I'm afraid we must use _sync variant here. disc_work is not supposed to >> > be running after hci_conn is deleted. >> > >> > BTW, I believe we already addressed this issue in patches [PATCH 1/2] >> > Bluetooth: Fix potential deadlock and [PATCH 2/2] Bluetooth: Remove >> > unneeded locking. These patches are now pushed upstream. Could you >> >> I will check those patches from upstream and let you know. > > crap, I just acked these. > > Johan, forget about my acks and just ignore them. Lets wait until we get > a clean new series. > > Regards > > Marcel This change is really wrong because we're on the delete path and Andre sent other patches which I'm almost sure will address this problem. Best regards, -- Ulisses Furquim ProFUSION embedded systems http://profusion.mobi Mobile: +55 19 9250 0942 Skype: ulissesffs -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
