Hi Marcel, On Mon, Jan 30, 2012 at 7:29 PM, Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote: > Hi Ulisses, > >> __cancel_delayed_work() is being used in some paths where we cannot >> sleep waiting for the delayed work to finish. However, that function >> might return while the timer is running and the work will be queued >> again. Replace the calls with safer cancel_delayed_work() version >> which spins until the timer handler finishes on other CPUs and >> cancels the delayed work. >> >> Signed-off-by: Ulisses Furquim <ulisses@xxxxxxxxxxxxxx> >> --- > > I have the feeling that I already looked at this patch before. And given > that it is v4, that might be true actually ;) > > Use the space between --- and diffstat to have some small changelog so I > know what was different to the previous version. Yes, you already seen this but I removed part of the patch to fix another problem. Sorry, forgot to include a message so you could know what has changed. >> include/net/bluetooth/l2cap.h | 4 ++-- >> net/bluetooth/l2cap_core.c | 6 +++--- >> 2 files changed, 5 insertions(+), 5 deletions(-) > > Acked-by: Marcel Holtmann <marcel@xxxxxxxxxxxx> > > Regards > > Marcel Regards, -- Ulisses Furquim ProFUSION embedded systems http://profusion.mobi Mobile: +55 19 9250 0942 Skype: ulissesffs -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html