Re: [PATCH 2/2] Bluetooth: Use GFP_KERNEL in hci_chan_create()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andre,

On Mon, Jan 30, 2012 at 10:22 AM, Andre Guedes
<andre.guedes@xxxxxxxxxxxxx> wrote:
> This function is called in process context only, so it should use
> GFP_KERNEL to allocate memory.
>
> Signed-off-by: Andre Guedes <andre.guedes@xxxxxxxxxxxxx>
> ---
>  net/bluetooth/hci_conn.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c
> index 9ec7b8e..7b38a0b 100644
> --- a/net/bluetooth/hci_conn.c
> +++ b/net/bluetooth/hci_conn.c
> @@ -945,7 +945,7 @@ struct hci_chan *hci_chan_create(struct hci_conn *conn)
>
>        BT_DBG("%s conn %p", hdev->name, conn);
>
> -       chan = kzalloc(sizeof(struct hci_chan), GFP_ATOMIC);
> +       chan = kzalloc(sizeof(struct hci_chan), GFP_KERNEL);
>        if (!chan)
>                return NULL;
>

The two patches to use GFP_KERNEL seem ok to me and that's the path
Padovan and Marcel wanted to go, of course, now that we run in process
context.

Best regards,

-- 
Ulisses Furquim
ProFUSION embedded systems
http://profusion.mobi
Mobile: +55 19 9250 0942
Skype: ulissesffs
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux