Hi Marcel, On Wed, Jan 18, 2012 at 5:53 PM, Johan Hedberg <johan.hedberg@xxxxxxxxx> wrote: > Hi Hemant, > > On Mon, Jan 16, 2012, Hemant Gupta wrote: >> This patch sends correct IO Capability response to remote device >> in case Local Device supports KeyBoardDisplay IO Capability as >> this capability is not valid as per BT spec for IO capability >> Request Reply Command. >> This capability is mapped to DisplayYesNo which is in accordance >> with BT spec. >> >> Signed-off-by: Hemant Gupta <hemant.gupta@xxxxxxxxxxxxxx> >> --- >> net/bluetooth/hci_event.c | 6 +++++- >> 1 files changed, 5 insertions(+), 1 deletions(-) >> >> diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c >> index d37f5b2..3590e72 100644 >> --- a/net/bluetooth/hci_event.c >> +++ b/net/bluetooth/hci_event.c >> @@ -2782,7 +2782,11 @@ static inline void hci_io_capa_request_evt(struct hci_dev *hdev, struct sk_buff >> struct hci_cp_io_capability_reply cp; >> >> bacpy(&cp.bdaddr, &ev->bdaddr); >> - cp.capability = conn->io_capability; >> + /* >> + * Change the IO capability from KeyboardDisplay >> + * to DisplayYesNo as it is not supported by BT spec. >> + */ >> + cp.capability = (conn->io_capability == 0x04) ? 0x01 : conn->io_capability; >> conn->auth_type = hci_get_auth_req(conn); >> cp.authentication = conn->auth_type; > > Looks good to me but this still needs Marcel's ack before I apply it to > my bluetooth-next tree. > > Johan Could you please provide comments on this patch, as with the application of BlueZ patch, SSP pairing would not work in case local device has set the IO Capability to KeyboardDisplay (0x04). -- Best Regards Hemant Gupta ST-Ericsson India -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
