Re: [PATCH v2] Bluetooth: Remove usage of __cancel_delayed_work()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Marcel,

On Sat, Jan 21, 2012 at 2:46 PM, Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote:
>
> Hi Ulisses,
>
> > __cancel_delayed_work() is being used in some paths where we cannot
> > sleep waiting for the delayed work to finish. However, that function
> > might return while the timer is running and the work will be queued
> > again. Replace the calls with safer cancel_delayed_work() version
> > which spins until the timer handler finishes in other CPUs and
> > cancels the delayed work.
> >
> > Signed-off-by: Ulisses Furquim <ulisses@xxxxxxxxxxxxxx>
> > ---
> >
> > v2 - rebased against newer bluetooth-next
> >
> >  include/net/bluetooth/l2cap.h |    4 ++--
> >  net/bluetooth/l2cap_core.c    |   10 +++++-----
> >  2 files changed, 7 insertions(+), 7 deletions(-)
>
> looks fine to me.
>
> Acked-by: Marcel Holtmann <marcel@xxxxxxxxxxxx>

Great. However, Johan please wait to apply. I'll send another version
with 2 patches including a fix for a possible crash.

Regards,

--
Ulisses Furquim
ProFUSION embedded systems
http://profusion.mobi
Mobile: +55 19 9250 0942
Skype: ulissesffs
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux