Re: [PATCH BlueZ 1/2] Add Proximity Reporter API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Johan,

On Wed, Jan 18, 2012 at 8:17 AM, Johan Hedberg <johan.hedberg@xxxxxxxxx> wrote:
> Hi Claudio,
>
> On Fri, Jan 13, 2012, Claudio Takahasi wrote:
>> +Proximity Reporter hierarchy
>> +===========================
>> +
>> +Service used by Proximity Path Loss and Find Me. Allows per device
>> +alert level handling.
>> +
>> +Service              org.bluez
>> +Interface    org.bluez.ProximityReporter
>> +Object path  [variable prefix]/{hci0,hci1,...}
>> +
>> +Methods
>> +
>> +
>> +Signals              ImmediateAlertLevelChanged(object device, string value)
>> +
>> +                     This signal indicates that Immediate Alert Level
>> +                     characteristic was changed by the remote device.
>> +                     Values: "none", "mild", "high".
>> +
>> +Properties
>
> Shouldn't ImmediateAlertLevel and LinkLossAlertLevel be defined as
> properties and then you'd have PropertyChanged instead of these custom
> signals?

Initially, we discarded one approach where we could have Properties on
the _device_ object path, because we would need to monitor each new
created device, check if it has the Immediate/LinkLossAlertLevel
property on the ProximityReporter interface, and if so, listen to the
PropertyChanged signal. This seems too much overhead IMHO.

Unless you are proposing keeping the interface and properties on the
adapter object path? In this case, we will lose the information about
the peer device which issued the alert. I'm unsure if this is a big
problem or not (given that the alert is "global" to the Proximity
Reporter, not a per peer state).

On the other hand, this "custom signal" approach allows to have only
one (or two) listener, no matter how many devices are connected to the
reporter, and still know which peer triggered the alert.

One benefit of knowing which device triggered the alert, is to have
custom alerts (e.g. different sounds) for each device, or if the
reporter has a display, show which device is making alerts.

Any ideas?
-- 
Anderson Lizardo
Instituto Nokia de Tecnologia - INdT
Manaus - Brazil
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux