Re: [PATCH 1/5] Bluetooth: Make l2cap_clear_timer return if timer was running or not

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Szymon,

> > so I am enforcing this now. No more empty commit message bodies!
> > 
> > Explain your patch and why do you need it. This is the perfect example
> > where you mention ahead of time why you want this.
> 
> I'll squash 1 and 2 then and add some more explanation.

I prefer you keep the separation. The splitting of your patches is
actually the part I liked a lot. They were logically separated. You just
need to be a bit more verbose with your commit messages to describe what
you are doing and why.

Bad luck that you are the first one where I am enforcing this now, but
that is just life. Blame all the others that send in patches with crappy
commit messages ;)

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux