Hi Santiago, On Mon, Dec 19, 2011 at 10:54 AM, Santiago Carot <sancane@xxxxxxxxx> wrote: > Hi, > > 2011/12/19 Santiago Carot <sancane@xxxxxxxxx>: >> Hi Anderson, >> >> 2011/12/19 Anderson Lizardo <anderson.lizardo@xxxxxxxxxxxxx>: >>> Hi Santiago, >>> >>> On Mon, Dec 19, 2011 at 10:35 AM, Santiago Carot <sancane@xxxxxxxxx> wrote: >>>>> Is there race condition here? Remember that plugins can also register >>>>> an adapter driver. >>>>> If a GATT "plugin" wants to register attributes during the probing the >>>>> attribute server needs to be ready. >>>>> >>>> >>>> I know that, remember these are transactional patches towardas >>>> multi-adapter support. They only prepare the environment to start >>>> coding. The patch 11 fixes this issue. In fact, one could think that >>>> it should in this place but when I started coding it I thought it was >>>> easier to reutilize functions which were already implemented and >>>> change it after multi-adapter started working. >>> > > Sorry: patch 10 is supposed to deal with that :P Ok. Now it makes sense :) I still had not time to review the full series (only took a look on Claudio comments). Still, I'm not sure adding a whole adapter driver just to remove it later on the same series is worth the trouble. Looks like you are fixing an issue introduced on the same series. Is it possible for you to rearrange the series so it is not necessary to introduce the adapter driver? If not, please improve the patches commit messages to explain why it is introduced (and the known problems), and that it is removed on a later patch. This helps a lot tracing regressions later. Best Regards, -- Anderson Lizardo Instituto Nokia de Tecnologia - INdT Manaus - Brazil -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
