Re: [PATCH 01/11] attrib-server: Initial steps to provide multi-adapter GATT server support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Santiago,

On Mon, Dec 19, 2011 at 10:08 AM, Claudio Takahasi
<claudio.takahasi@xxxxxxxxxxxxx> wrote:
>> +static struct btd_adapter_driver attrib_adapter_driver = {
>> +       .name   = "attrib-adapter-driver",
>> +       .probe  = attrib_adapter_probe,
>> +       .remove = attrib_adapter_remove,
>> +};
>
> Is there race condition here? Remember that plugins can also register
> an adapter driver.
> If a GATT "plugin" wants to register attributes during the probing the
> attribute server needs to be ready.

I agree with Claudio here. We should not rely on adapter drivers for
initializing the attribute server (although I previously thought it
could be that simple as well). Otherwise, plugins can't also use
adapter driver's probe() to register attributes , which defeats the
idea of per-adapter ATT attributes.

I think the attribute server should be initialized at an early stage,
after the adapter is created, but prior to having the adapter drivers
called.

Regards,
-- 
Anderson Lizardo
Instituto Nokia de Tecnologia - INdT
Manaus - Brazil
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux