Re: [PATCHv2] mgmt: Add support for Passkey handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Johan,

On Thu, Dec 15, 2011 at 5:38 PM, Johan Hedberg <johan.hedberg@xxxxxxxxx> wrote:
> Hi Hemant,
>
> On Thu, Dec 15, 2011, Hemant Gupta wrote:
>> @@ -218,7 +218,7 @@ struct mgmt_rp_user_confirm_reply {
>>  #define MGMT_OP_USER_PASSKEY_REPLY   0x001C
>>  struct mgmt_cp_user_passkey_reply {
>>       bdaddr_t bdaddr;
>> -     uint32_t passkey;
>> +     __le32 passkey;
>>  } __packed;
>
> Otherwise the patch looks ok but this change shouldn't be in it.  __le32
> is only for the kernel side.
>
Tanks for the comment, I used it since the kernel was using le32, and
the structure
allocated was u32? Dont we require to do the type casting?
> Johan
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Best Regards
Hemant Gupta
ST-Ericsson India
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux