Re: [PATCH 2/4] mcap_sync.c: Fix include paths

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

2011/12/15 Johan Hedberg <johan.hedberg@xxxxxxxxx>:
> Hi Santiago,
>
> On Wed, Dec 14, 2011, Santiago Carot-Nemesio wrote:
>> ---
>>  health/mcap_sync.c |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/health/mcap_sync.c b/health/mcap_sync.c
>> index 5545cea..e2d7715 100644
>> --- a/health/mcap_sync.c
>> +++ b/health/mcap_sync.c
>> @@ -28,8 +28,8 @@
>>  #include <stdlib.h>
>>  #include <bluetooth/bluetooth.h>
>>  #include <bluetooth/l2cap.h>
>> -#include "../src/adapter.h"
>> -#include "../src/manager.h"
>> +#include <adapter.h>
>> +#include <manager.h>
>>  #include <sys/ioctl.h>
>>
>>  #include "config.h"
>
> There's more to fix here than this. config.h should come before anything
> else (and should be inside a #ifdef HAVE_CONFIG_H) and we sort the libc
> includes first, then dbus,glib,etc and finally the bluez internal
> includes.
>

You are right, I didn't notice it. I'll send a new patch solving this issue.
Regards.
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux