Re: [PATCH BlueZ 4/5] Remove the default security level from btio

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Chen,

On Wed, Dec 14, 2011 at 8:43 AM, Ganir, Chen <chen.ganir@xxxxxx> wrote:
> Vinicius
>
>> -----Original Message-----
>> From: linux-bluetooth-owner@xxxxxxxxxxxxxxx [mailto:linux-bluetooth-
>> owner@xxxxxxxxxxxxxxx] On Behalf Of Vinicius Costa Gomes
>> Sent: Wednesday, December 14, 2011 1:58 AM
>> To: linux-bluetooth@xxxxxxxxxxxxxxx
>> Cc: Vinicius Costa Gomes
>> Subject: [PATCH BlueZ 4/5] Remove the default security level from btio
>>
>> The default value of sec_level when setting *any* option
>> using bt_io_set() was BT_SECURITY_MEDIUM. This was causing
>> the security procedure being started in some situations that
>> it should not.
>> ---
>>  btio/btio.c |    1 -
>>  1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/btio/btio.c b/btio/btio.c
>> index 5641a9c..c26a734 100644
>> --- a/btio/btio.c
>> +++ b/btio/btio.c
>> @@ -698,7 +698,6 @@ static gboolean parse_set_opts(struct set_opts
>> *opts, GError **err,
>>       /* Set defaults */
>>       opts->defer = DEFAULT_DEFER_TIMEOUT;
>>       opts->master = -1;
>> -     opts->sec_level = BT_IO_SEC_MEDIUM;
>
> So removing this simply sets the default security level to none ?

Yes. But this is a fix for an API bug, that if I don't want the
security level to increase to medium
when setting an option using btio, I need to specify the security
level on bt_io_set().

>
>>       opts->mode = L2CAP_MODE_BASIC;
>>       opts->flushable = -1;
>>       opts->priority = 0;
>> --
>> 1.7.8
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-
>> bluetooth" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
>
> Thanks,
> Chen Ganir
>


Cheers,
-- 
Vinicius
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux