How about adding Dbus log in gdbus?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello

How about adding dbus log in gdbus when we get method call from the remote peer(application)?

Personally It could be very useful for begginer.Based on it many people could understand call procedure easily. As far as I know this was removed when bluez 3.xx. but compared to the days,
recently many dbus APIs have been introduced.

But I know it is relatetd to many projects(bluez,obexd,connman,ofono).
So we need to consider a few things such as dependency managing and user preference.
because curren gdbus does not have dependency with log.c/log.h.

Is there good idea about this?


BR
Chanyeol Park.

diff --git a/gdbus/object.c b/gdbus/object.c
index 8bc12f5..ac7f448 100644
--- a/gdbus/object.c
+++ b/gdbus/object.c
@@ -33,9 +33,7 @@

 #include "gdbus.h"

-#define info(fmt...)
-#define error(fmt...)
-#define debug(fmt...)
+#include "log.h"

 struct generic_data {
        unsigned int refcount;
@@ -444,6 +442,9 @@ static DBusHandlerResult generic_message(DBusConnection *connection,
                                                iface->user_data) == TRUE)
                        return DBUS_HANDLER_RESULT_HANDLED;

+               DBG("%s: %s.%s()",dbus_message_get_path(message),
+                                               iface->name,method->name);
+
                return process_message(connection, message, method,
                                                        iface->user_data);
        }


Thanks
Chanyeol Park
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux