Re: [RFC obexd v2 07/21] client: GetCapabilities moved to session API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Again,

On Fri, Dec 9, 2011 at 2:07 PM, Luiz Augusto von Dentz
<luiz.dentz@xxxxxxxxx> wrote:
>> +static DBusMessage *get_capabilities(DBusConnection *connection,
>> +                                       DBusMessage *message, void *user_data)
>> +{
>> +       struct obc_session *session = user_data;
>> +
>> +       obc_session_pull(session, "x-obex/capability", NULL,
>> +                               capabilities_complete_callback,
>> +                               dbus_message_ref(message));
>
> I guess you should probably mark this method as async, this way you
> don't need to reference the message. Actually I don't think this works
> without it having G_DBUS_METHOD_FLAG_ASYNC, if you return NULL as you
> did bellow gdbus will return DBUS_HANDLER_RESULT_NEED_MEMORY to
> libdbus.
>

Btw we should probably add a watch to the application so we are able
to cancel the request if the application disconnects before we reply.

-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux