Re: [PATCH 1/3] Fix dbus reply memory leak

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Johan,
On 12/2/2011 4:45 PM, Johan Hedberg wrote:
Hi Syam,

On Thu, Nov 24, 2011, Syam Sidhardhan wrote:
---
  audio/telephony-maemo5.c |    8 ++++----
  cups/main.c              |   30 +++++++++++++++++++++++++-----
  test/agent.c             |    2 ++
  test/mpris-player.c      |    6 +++++-
  4 files changed, 36 insertions(+), 10 deletions(-)
Your commit message uses the word leak in singular form but there are
multiple fixes in this patch, i.e. the commit message is misleading. In
this case I'd split the patch into four separate ones:

telephony-maemo5: Fix D-Bus reply memory leaks
cups: Fix D-Bus reply memory leaks
agent: Fix D-Bus reply memory leaks
mpris-player: Fix D-Bus reply memory leaks

Johan

Yes, you are correct. You can split it into multiple patches.
Thanks in advance.

Syam
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux