Re: [PATCH 2/3] Remove unwanted GError* assignment to NULL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Syam,

On Thu, Nov 24, 2011, Syam Sidhardhan wrote:
> ---
>  health/hdp.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/health/hdp.c b/health/hdp.c
> index d167ab0..403d4c8 100644
> --- a/health/hdp.c
> +++ b/health/hdp.c
> @@ -551,7 +551,6 @@ static void hdp_get_dcpsm_cb(uint16_t dcpsm, gpointer user_data, GError *err)
>  	hdp_tmp_dc_data_unref(hdp_conn);
>  	hdp_conn->cb(hdp_chann->mdl, err, hdp_conn);
>  	g_error_free(gerr);
> -	gerr = NULL;
>  }

Applied, however a bigger question is whether gerr is even needed in
this function at all since it's never used after potentially being set.

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux