Hi Marcel, On Wed, Nov 30, 2011 at 03:31:24PM +0100, Marcel Holtmann wrote: > Hi Andrei, > > > The code adds AMP HCI commands from A2MP protocol. HCI events are handled > > similar way as mgmt interface. amp_pending is a kind of copy of mgmt_pending. > > this is all kernel internal code with no interface to user space. I do > not see the need for such a complex infrastructure. Can not just have > proper callbacks or event callback table like with L2CAP. Or just > something similar. I see this as a simple callback. amp_pending is just keeping context of HCI command we need to handle. I also included reference counting since we had bad experience with l2cap and rfcomm. > As far as I see it, we get an A2MP command over L2CAP fixed channel, we > have to issue a HCI command or do some other task based on this and then > respond to it. We only have one user of this first of all. And second of > all, I think we can not really have pending A2MP commands anyway. This > is pretty much one command at a time (per ACL link). The picture "Figure 7.1: Overview MSC for physical link create/accept" BLUETOOTH SPECIFICATION Version 4.0 [Vol 5] page 49 of 60 shows quite a lot of commands between A2MP messages, I feel that if we have just callback from HCI event to handle A2MP responses it might be difficult to sync them. Best regards Andrei Emeltchenko > If I am mistaken here, please correct here. It has been a while since I > read that specification. > > Regards > > Marcel > > -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
