Re: [PATCHv3 3/3] Bluetooth: trivial: correct check for LMP version

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Marcel,

On Wed, Nov 30, 2011 at 03:13:17PM +0100, Marcel Holtmann wrote:
> Hi Andrei,
> 
> > Make sure that code match exactly what comment says about pre 1.2
> > LMP version.
> > 
> > Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@xxxxxxxxx>
> > ---
> >  net/bluetooth/hci_event.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> Acked-by: Marcel Holtmann <marcel@xxxxxxxxxxxx>
> 
> > 
> > diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
> > index 60651fa..27b1ede 100644
> > --- a/net/bluetooth/hci_event.c
> > +++ b/net/bluetooth/hci_event.c
> > @@ -498,7 +498,7 @@ static void hci_setup_event_mask(struct hci_dev *hdev)
> >  
> >  	/* CSR 1.1 dongles does not accept any bitfield so don't try to set
> >  	 * any event mask for pre 1.2 devices */
> > -	if (hdev->lmp_ver <= BLUETOOTH_VER_1_1)
> > +	if (hdev->lmp_ver < BLUETOOTH_VER_1_2)
> >  		return;
> 
> However, even here you need to use hci_ver since it is a HCI detail and
> has nothing to do with the LMP version.

Do you think can I amend this patch and change lmp/hci ?

Best regards 
Andrei Emeltchenko 
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux