Hi Johan,
On 11/18/2011 12:12 PM, Johan Hedberg wrote:
Hi Brian,
On Fri, Nov 18, 2011, Brian Gix wrote:
I would support migrating ATT to the kernel.
Same here.
In fact another issue I have dealt with is ensuring during Pairing,
that we are able to at least respond with minimal Error responses if
someone tries to read our name, and there is no GATT client socket to
user space to respond.
This issue was already encountered during the last UPF and INdT has a
fix for it. For whatever reason that fix doesn't seem to have showed up
here on the mailing list for upstreaming. In general the capability of
doing ATT signaling should be available as soon as we have a connection
handle, and it should be independent of any ongoing SMP procedure. Only
if the characteristic accessed requires higher security than is
currently provided by the LE link should the ATT procedures fail with an
error. In the use case you describe, since the Name characteristic
doesn't have any special security requirements a request for it should
be always responded to with a positive reply regardless of the current
level of security or if there's an ongoing SMP operation.
I have the solution to return an error that I could upstream if needed.
It worked sufficiently well to get past the UPF testing scenario's
where it was an issue, but as you point out, it should never return an
error in the first place. However, as a stop-gap temporary solution, it
works quite well.
--
Brian Gix
bgix@xxxxxxxxxxxxxx
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
