[PATCH BlueZ] serial: Fix error handling in connect_port()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



bt_io_connect() does not set errno on error, instead it uses GError. For
now, simply return -EIO if bt_io_connect() fails. The serial plug-in
code can be changed later to use and set GError appropriately.
---
 serial/port.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/serial/port.c b/serial/port.c
index 3b36d44..5b76d14 100644
--- a/serial/port.c
+++ b/serial/port.c
@@ -463,10 +463,10 @@ connect:
 				BT_IO_OPT_DEST_BDADDR, &device->dst,
 				BT_IO_OPT_CHANNEL, port->channel,
 				BT_IO_OPT_INVALID);
-	if (port->io)
-		return 0;
+	if (port->io == NULL)
+		return -EIO;
 
-	return -errno;
+	return 0;
 }
 
 static struct serial_port *create_port(struct serial_device *device,
-- 
1.7.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux