RE: [PATCH v3 bluez 2/2] Add A2MP definitions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andrei,

> > +
> > +/* AMP controller type */
> > +#define AMP_CTRL_BR_EDR		0x00
> > +#define AMP_CTRL_802_11		0x01
> 
> Do we need to define those values? Cannot you use already defined ones in
> hci.h?

You're right, I'll remove them.

> in include/net/bluetooth/hci.h and lib/hci.h
> /* HCI controller types */
> #define HCI_BREDR       0x00
> #define HCI_AMP         0x01
> 
> Maybe HCI_AMP is not the best way and at some point we might need to
> rename it according to BT Spec assigned numbers (like HCI_AMP_802_11)

Agreed it should be changed to reflect 802.11.

> Otherwise
> 
> Acked-by: Andrei Emeltchenko <andrei.emeltchenko@xxxxxxxxx>

Regards,

Peter.

--Peter Krystad
  Employee of Qualcomm Innovation Center, Inc.
  Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum


--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux