Re: [PATCH 6/6] Bluetooth: Support LE-Only discovery procedure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andrei,

On Nov 17, 2011, at 5:59 AM, Andrei Emeltchenko wrote:

> Hi Andre,
> 
> On Wed, Nov 16, 2011 at 05:36:38PM -0300, Andre Guedes wrote:
> 
> ...
> 
>>>> 
>>>> 	if (cp->enable == 0x01) {
>>> 
>>> Can we fix also magic number here and below?
>> 
>> I see your point here, but this is not a magic number, it is
>> just a true/false value.
> 
> If this true/false no need to compare with hex numbers why not
> 
> if(cp->enable) 
> 	...

Yes, sure, it could be done like that. I might do it in a later
patch so.

Thanks,

Andre
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux