Hi Marcel, On Wed, Nov 16, 2011 at 02:48:24PM +0900, Marcel Holtmann wrote: > Hi Andrei, > > > Type can be changed during re-opening device /dev/vhci. > > > > Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@xxxxxxxxx> > > --- > > drivers/bluetooth/hci_vhci.c | 10 ++++++++++ > > 1 files changed, 10 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/bluetooth/hci_vhci.c b/drivers/bluetooth/hci_vhci.c > > index 2e302a1..ac08adc 100644 > > --- a/drivers/bluetooth/hci_vhci.c > > +++ b/drivers/bluetooth/hci_vhci.c > > @@ -41,6 +41,8 @@ > > > > #define VERSION "1.3" > > > > +static bool amp; > > + > > struct vhci_data { > > struct hci_dev *hdev; > > > > @@ -239,6 +241,11 @@ static int vhci_open(struct inode *inode, struct file *file) > > hdev->bus = HCI_VIRTUAL; > > hdev->driver_data = data; > > > > + if (amp) { > > + hdev->dev_type = HCI_AMP; > > + hdev->amp_status = AMP_CTRL_BLUETOOTH_ONLY; > > + } > > + > > I do not like doing this. You are not squeezing two patches into one. > Please keep them separate. I already acked the previous one. OK I will resend as 2 patches. Because I changed the patch I have removed your ack. Best regards Andrei Emeltchenko -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html