Hi Brian, > Passkey entry and comparison only. Uses MGMT interface to request > passkey and confirmation from user space. can you please split this patch into smaller chunks. It looks like some of them are just small bug fixes for error handling. And I see a lot of code duplication here as well. I prefer we introduce proper helpers for certain common patterns. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html