Re: [PATCH 3/5] Bluetooth: Add User Passkey entry to HCI Events

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Sat, Nov 12, 2011, Marcel Holtmann wrote:
> > +static inline void hci_user_passkey_request_evt(struct hci_dev *hdev,
> > +							struct sk_buff *skb)
> > +{
> > +	struct hci_ev_user_passkey_req *ev = (void *) skb->data;
> > +
> > +	BT_DBG("%s", hdev->name);
> > +
> > +	hci_dev_lock(hdev);
> > +
> > +	/* Passkey Request is a degenerate case of User Confirm */
> > +	if (test_bit(HCI_MGMT, &hdev->flags))
> > +		mgmt_user_confirm_request(hdev, &ev->bdaddr, 0, 0);
> > +	else
> > +		hci_send_cmd(hdev, HCI_OP_USER_PASSKEY_NEG_REPLY,
> > +					sizeof(ev->bdaddr), &ev->bdaddr);
> 
> We might want a comment here that this needs fixing ;)

If HCI_MGMT isn't set this code should do nothing. In such a case it's
likely that hciops is running in user-space and will take care of this
request.

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux