Hi Marcel, On Fri, Nov 11, 2011 at 11:29:57PM +0900, Marcel Holtmann wrote: > Hi Andrei, > > > net/bluetooth/hci_core.c | 6 ++++-- > > 1 files changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c > > index 189bada..1b08e4b 100644 > > --- a/net/bluetooth/hci_core.c > > +++ b/net/bluetooth/hci_core.c > > @@ -51,6 +51,7 @@ > > > > #include <net/bluetooth/bluetooth.h> > > #include <net/bluetooth/hci_core.h> > > +#include <net/bluetooth/l2cap.h> > > > > #define AUTO_OFF_TIMEOUT 2000 > > > > @@ -570,8 +571,9 @@ int hci_dev_open(__u16 dev) > > if (test_bit(HCI_QUIRK_RAW_DEVICE, &hdev->quirks)) > > set_bit(HCI_RAW, &hdev->flags); > > > > - /* Treat all non BR/EDR controllers as raw devices for now */ > > - if (hdev->dev_type != HCI_BREDR) > > + /* Treat all non BR/EDR controllers as raw devices if > > + enable_hs is not set */ > > + if (hdev->dev_type != HCI_BREDR && !enable_hs) > > set_bit(HCI_RAW, &hdev->flags); > > this is fine with me. Even while the include of l2cap.h is kinda nasty. > Maybe the enable_hs variable actually needs to be moved into hci_*.c > files and not stay inside L2CAP. I agree that moving enable_hs to hci header is better. Will resend with this change. Best regards Andrei Emeltchenko > > Acked-by: Marcel Holtmann <marcel@xxxxxxxxxxxx> > > Regards > > Marcel > > -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
