On 11/7/2011 2:58 PM, Gustavo Padovan wrote:
Hi Brian,
* Brian Gix<bgix@xxxxxxxxxxxxxx> [2011-11-07 14:00:16 -0800]:
Implemented missing components of MGMTOPS interface
Differentiated as needed between BR/EDR pairing and LE pairing
These are a combination of changes we made to get make MGMTOPS more
robust, and provide MITM pairing options for LE. Much work has been
put into
merging these changes into the current master branch of Bluetooth Next, but
they have not been extensively tested on that build.
This is anticipated to be the first step towards upstreaming these changes,
Signed-off-by: Brian Gix<bgix@xxxxxxxxxxxxxx>
---
include/net/bluetooth/hci.h | 36 ++
include/net/bluetooth/hci_core.h | 32 ++-
include/net/bluetooth/l2cap.h | 5 +
include/net/bluetooth/mgmt.h | 24 ++-
include/net/bluetooth/smp.h | 14 +-
net/bluetooth/hci_conn.c | 58 +++-
net/bluetooth/hci_core.c | 64 +++-
net/bluetooth/hci_event.c | 166 ++++++---
net/bluetooth/hci_sock.c | 9 +-
net/bluetooth/l2cap_core.c | 15 +-
net/bluetooth/mgmt.c | 743
++++++++++++++++++++++++++++++++------
net/bluetooth/smp.c | 661 ++++++++++++++++++++++++---------
12 files changed, 1441 insertions(+), 386 deletions(-)
We really appreciate your contribution to upstream, but this need to be
broken in more patches, otherwise its impossible to me review and accept it.
Try to split this in logical and atomic changes, upstream the easiest things
first, like small l2cap or smp changes. New MGMT commands need one commit
for each because they need to be discussed and so on.
The are many examples of this in the mailing list.
Gustavo
I understand. This was a first rough pass, which I expect to undergo a
variety of changes, including but not limited to conformance to the
MGMTOPS api as agreed upon in Prague, and the splitting into many more
smaller patches. I did not intend for this single behemoth to be
accepted in whole or in part at this point, but rather as a delivery
mechanism for those who have been waiting for something that actually
could be used with mainline code, which was impossible in the form we
had published elsewhere. This is why I chose RFC rather than PATCH in
the subject header.
--
Brian Gix
bgix@xxxxxxxxxxxxxx
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
